Team up for Converting AzerothCore Modules to latest TrinityCore

[madmax1337]

Hello, im looking for help to convert some AzerothCore Modules to latest TrinityCore 3.3.5a.
Commit [3b863f6]

Every help is welcome to improve the Modules.


If you have interess, please feel free to add me on discord.

TheFrozenThr0ne 蛇
#3075


To Convert [Done]
- https://github.com/StygianTheBest/Az...master/Modules


Converted Modules
- https://github.com/MaDmaX1337/Azerot...st-TrinityCore

[0Voltage]

Wish you all the best!

[mindsear]

Try:

bool OnGossipSelectCode(Player* player, uint32 menuId, uint32 gossipListId, const char* code)             
        {
           uint32 const sender = player->PlayerTalkClass->GetGossipOptionSender(gossipListId);

Also, this conditional expression makes no sense

if (!code)
  {
     code = "";
  }

[madmax1337]

Try:

bool OnGossipSelectCode(Player* player, uint32 menuId, uint32 gossipListId, const char* code)             
        {
           uint32 const sender = player->PlayerTalkClass->GetGossipOptionSender(gossipListId);

Also, this conditional expression makes no sense

if (!code)
  {
     code = "";
  }

Great thank you, atleast the NPC saying when the code is invalid. Now i need to figure out why i do not getting loot from specify Code. Do you have a clue?

[mindsear]

Seems strange, I tested your script and it's working for me.

[madmax1337]

Seems strange, I tested your script and it's working for me.

Thanks it is working, i copy and paste the code to the code box and it is working fine. Not sure why i had to copy and paste but nvm. It may caused through a addon i think so.

[AwkwardDev]

Try:

bool OnGossipSelectCode(Player* player, uint32 menuId, uint32 gossipListId, const char* code)             
        {
           uint32 const sender = player->PlayerTalkClass->GetGossipOptionSender(gossipListId);

Also, this conditional expression makes no sense

if (!code)
  {
     code = "";
  }

That's the least part of it all really ...

@madmax1337, I wonder, by converting you mean that you're just fixing the compatibility of the C++ logic across the 2 platforms?

[madmax1337]

Yes, lets say that. I make it working for WotLk. And im glad for all the help.

[AwkwardDev]

Noble endeavor, although most of these codes are awful ... Or well, can be done a lot better and simpler ...

[madmax1337]

Noble endeavor, although most of these codes are awful ... Or well, can be done a lot better and simpler ...

I understand, well i just started to understand these codes and trying my best what i can to done my task. Even when i can not done every Module from AzerothCore because my knowledge is a bit low for the complexe scripts like transmog, for this i need help but i may come back later when i try to fix it for WotLk. At least I managed a few.

[mindsear]

I understand, well i just started to understand these codes and trying my best what i can to done my task. Even when i can not done every Module from AzerothCore because my knowledge is a bit low for the complexe scripts like transmog, for this i need help but i may come back later when i try to fix it for WotLk. At least I managed a few.

I do believe Rochet2 is keeping his scripts updated.

Rochet2 Transmog 3.3.5: https://github.com/Rochet2/TrinityCo...ustom/Transmog - updated 6 months ago.

[madmax1337]

Yes great thank you for the information, im using it already.

[mindsear]

- - - Updated - - -


If someone can help me fix this script, almost everything works, if i choose a pet then the server will crash. I can't figure out the issue.

https://github.com/MaDmaX1337/Azerot...npcbeastmaster

I converted Npc_beastmaster a few months ago and I believe it's still relevant to the latest TC rev 3.3.5

gist.github.com Npc_beastmaster.cpp: https://gist.github.com/mindsear/44e...35ece83df32770